RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body [v3]

Daniel Fuchs dfuchs at openjdk.org
Thu Dec 15 18:08:10 UTC 2022


On Thu, 15 Dec 2022 10:23:22 GMT, Michal Karm Babacek <duke at openjdk.org> wrote:

>> According to [rfc6455](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1), the close frame MAY contain a body, i.e. it is considered [optional](https://www.rfc-editor.org/rfc/rfc2119#section-5). It seems that the contemporary JDK HEAD (tip) does populate the body and thus enables `HandshakeUrlEncodingTest.java` to parse its contents. On the contrary, JDK 11 does not populate the body in the same case. I would like to backport JDK-8245245 all the way to JDK 11, so I would like to change the behavior of this test so as it works across JDK versions.
>
> Michal Karm Babacek has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Response body is always checked

This looks good to me! Thanks for improving this test. Please double check it still passes before integrating :-)

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11486


More information about the net-dev mailing list