RFR: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes [v2]

[Jaikiran Pai]

On Tue, 20 Dec 2022 10:29:11 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> The implementation of `BodySubscribers.ofFile` does not correctly handle the case of a short gathering write. The write should be retried until all the bytes have been written to the underlying file.
>> 
>> This is generally not an issue that would occur very frequently, since the `IOV_MAX` is commonly 1024 on Mac/Linux, and 16 on Windows. However, it is clearly a bug, and should be fixed.
>
> Chris Hegarty has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments: 1) remove MAX_INT restriction, and 2) check 0 write

src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 289:

> 287:                 ByteBuffer[] buffers = items.toArray(Utils.EMPTY_BB_ARRAY);
> 288:                 while (bytesWritten < size) {
> 289:                     bytesWritten += out.write(buffers);

Should we handle the potential case of long value overflow, after addition here, which could then cause the while loop to misbehave?

-------------

PR: https://git.openjdk.org/jdk/pull/11722