RFR: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes [v2]
Daniel Fuchs
dfuchs at openjdk.org
Tue Dec 20 10:42:28 UTC 2022
On Tue, 20 Dec 2022 10:33:29 GMT, Chris Hegarty <chegar at openjdk.org> wrote:
>> The implementation of `BodySubscribers.ofFile` does not correctly handle the case of a short gathering write. The write should be retried until all the bytes have been written to the underlying file.
>>
>> This is generally not an issue that would occur very frequently, since the `IOV_MAX` is commonly 1024 on Mac/Linux, and 16 on Windows. However, it is clearly a bug, and should be fixed.
>
> Chris Hegarty has updated the pull request incrementally with one additional commit since the last revision:
>
> review comments: 1) remove MAX_INT restriction, and 2) check 0 write
Well this has the potential of creating a busy loop since bytesWritten will not increase if zero is returned.
-------------
PR: https://git.openjdk.org/jdk/pull/11722
More information about the net-dev
mailing list