RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java [v2]
Jaikiran Pai
jpai at openjdk.java.net
Thu Jan 13 03:26:58 UTC 2022
> Can I please get a review for this test only change which proposes to enable debug logs from the test that failed intermittently? This change addresses https://bugs.openjdk.java.net/browse/JDK-8278961.
>
> The change passes the (test specific) `-d` option to enable logs from that test by default. While I was at it, I even added a few more debug logs hoping it might provide some hints if/when it fails next.
>
> For reference, a (successful) run of this test will now print something like:
>
>
> ----------System.out:(18/930)----------
> running on OS that supports ICMP port unreachable
> Testing with class java.net.DatagramSocket
> tests will be run against destination address localhost/127.0.0.1 port 52682
> Checking send to connected address ...
> socket is locally bound to address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> received data from address /127.0.0.1 port 52681
> Checking send to non-connected address ...
> received data from address /127.0.0.1 port 52681
> Checking send to invalid address ...
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
fix @bug in test definition and fix copyright year
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6883/files
- new: https://git.openjdk.java.net/jdk/pull/6883/files/721cd07d..387dc5d1
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6883&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6883&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/6883.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/6883/head:pull/6883
PR: https://git.openjdk.java.net/jdk/pull/6883
More information about the net-dev
mailing list