RFR: 8280494: (D)TLS signature schemes [v2]

[Xue-Lei Andrew Fan]

On Fri, 28 Jan 2022 00:54:53 GMT, Bernd <duke at openjdk.java.net> wrote:

>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 92:
> 
>> 90:     private int maximumPacketSize = 0;
>> 91:     private String[] applicationProtocols = new String[0];
>> 92:     private String[] signatureSchemes = new String[0];
> 
> There are some places in here which could use a local or global static EMPTY = new String[0]` value. That would be safe to share and reduces allocations (they surely escape).

Good point.  I will make the update.

> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 745:
> 
>> 743:      * This method will make a copy of the {@code signatureSchemes} array.
>> 744:      *
>> 745:      * @param signatureSchemes an ordered array of signature scheme names,
> 
> Should it mention that unknown schemes are ignored and not trigger a exception?

Good catch!  I missed that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7252