RFR: 8287593: ShortResponseBody could be made more resilient to rogue connections [v3]

[Daniel Fuchs]

On Fri, 1 Jul 2022 17:55:54 GMT, Ryan Ernst <duke at openjdk.org> wrote:

>> Since ReplyingServer binds to an open port on the system where tests
>> run, it is possible some other program probes that port while the test
>> is running. If the probe request does not have request params, the
>> request is invalid and a test assertion fails. This commit replaces that
>> assertion with returning a 400 response.
>
> Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into httpclient_test_assert
>  - better log message
>  - Merge branch 'master' into httpclient_test_assert
>  - 8287593: ShortResponseBody could be made more resilient to rogue connections
>    
>    Since ReplyingServer binds to an open port on the system where tests
>    run, it is possible some other program probes that port while the test
>    is running. If the probe request does not have request params, the
>    request is invalid and a test assertion fails. This commit replaces that
>    assertion with returning a 400 response.

Thanks for the updates! LGTM.

Make sure to run tier2 before integrating.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9329