RFR: 8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100 [v3]
Jaikiran Pai
jpai at openjdk.java.net
Thu Jun 9 14:19:49 UTC 2022
On Thu, 9 Jun 2022 11:46:22 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Conor Cleary has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - 8286171: Package-protected access for method
>> - 8286171: Added checks for correct response codes
>
> test/jdk/java/net/httpclient/ExpectContinueTest.java line 165:
>
>> 163: public void handle(HttpTestExchange exchange) throws IOException {
>> 164: //Send 417 Headers, tell client to not send body
>> 165: try (InputStream is = exchange.getRequestBody();
>
> Should we include a couple of other variants of the server to cover some other possible flows. For example:
>
> - Don't read the request body, but just send the 417 response header?
> - Send some other final response status code other than 100 or 417?
The suggestion is merely to verify that we have covered the necessary code paths related to this flow. You can skip this, if looking at the code you see that the current test covers it.
-------------
PR: https://git.openjdk.org/jdk/pull/9093
More information about the net-dev
mailing list