RFR: JDK-8286610: Add additional diagnostic output to java/net/DatagramSocket/InterruptibleDatagramSocket.java

Bill Huang duke at openjdk.org
Mon Jun 27 15:51:41 UTC 2022


On Mon, 27 Jun 2022 12:02:01 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> test/jdk/java/net/DatagramSocket/InterruptibleDatagramSocket.java line 101:
>> 
>>> 99:     public static void main(String[] args) throws Exception {
>>> 100:         try (DatagramSocket s = new DatagramSocket()) {
>>> 101:             System.out.println("Established uninterruptible datagram socket "
>> 
>> "Established uninterruptible datagram socket" is a bit strange. I think I you want to this to say "Created datagram socket bound to port %d".
>
> I think information on the scenario under test would be useful, such as, 
> "Testing interrupt of DatagramSocket  receive on endpoint " + s.getLocalSocketAddress()
> 
> "Testing interrupt of MulticastSocket receive on endpoint " + s.getLocalSocketAddress()
> 
> "Testing interrupt of DatagramChannel socket receive on endpoint " + s.getLocalSocketAddress()

Sure, I can change that.

-------------

PR: https://git.openjdk.org/jdk/pull/9278


More information about the net-dev mailing list