RFR: 8289291: HttpServer sets incorrect value for "max" parameter in Keep-Alive header value
Jaikiran Pai
jpai at openjdk.org
Wed Jun 29 10:31:07 UTC 2022
Can I please get a review for this change which addresses https://bugs.openjdk.org/browse/JDK-8289291?
As noted in that issue, right now, the Http(s)Server sets an incorrect value for the `max` parameter of the `Keep-Alive` header. The `max` value is supposed to be the number of subsequent requests that the server is willing to serve over that specific connection. The current value it sets is instead the number of idle connections that are configured for the server.
The commit in this PR removes that `max` parameter altogether, since it isn't mandated by the spec, nor does the Http(s)Server have any specific construct to come up with a right value. Furthermore, on the client side the HttpURLConnection based client doesn't mandate the presence of this parameter in the `Keep-Alive` header. So this change won't cause any regressions in that area.
tier1, tier2 and tier3 testing passed without any related issues after this change.
-------------
Commit messages:
- 8289291: HttpServer sets incorrect value for max parameter in Keep-Alive header value
Changes: https://git.openjdk.org/jdk/pull/9326/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9326&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8289291
Stats: 6 lines in 1 file changed: 0 ins; 1 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/9326.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9326/head:pull/9326
PR: https://git.openjdk.org/jdk/pull/9326
More information about the net-dev
mailing list