Integrated: 8289291: HttpServer sets incorrect value for "max" parameter in Keep-Alive header value
Jaikiran Pai
jpai at openjdk.org
Thu Jun 30 01:45:49 UTC 2022
On Wed, 29 Jun 2022 10:20:42 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review for this change which addresses https://bugs.openjdk.org/browse/JDK-8289291?
>
> As noted in that issue, right now, the Http(s)Server sets an incorrect value for the `max` parameter of the `Keep-Alive` header. The `max` value is supposed to be the number of subsequent requests that the server is willing to serve over that specific connection. The current value it sets is instead the number of idle connections that are configured for the server.
>
> The commit in this PR removes that `max` parameter altogether, since it isn't mandated by the spec, nor does the Http(s)Server have any specific construct to come up with a right value. Furthermore, on the client side the HttpURLConnection based client doesn't mandate the presence of this parameter in the `Keep-Alive` header. So this change won't cause any regressions in that area.
>
> tier1, tier2 and tier3 testing passed without any related issues after this change.
This pull request has now been integrated.
Changeset: dddd4e7c
Author: Jaikiran Pai <jpai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/dddd4e7c81fccd82b0fd37ea4583ce1a8e175919
Stats: 110 lines in 2 files changed: 104 ins; 1 del; 5 mod
8289291: HttpServer sets incorrect value for "max" parameter in Keep-Alive header value
Reviewed-by: michaelm, dfuchs
-------------
PR: https://git.openjdk.org/jdk/pull/9326
More information about the net-dev
mailing list