RFR: 8287593: ShortResponseBody could be made more resilient to rogue connections [v2]

Ryan Ernst duke at openjdk.org
Thu Jun 30 14:26:23 UTC 2022


> Since ReplyingServer binds to an open port on the system where tests
> run, it is possible some other program probes that port while the test
> is running. If the probe request does not have request params, the
> request is invalid and a test assertion fails. This commit replaces that
> assertion with returning a 400 response.

Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into httpclient_test_assert
 - 8287593: ShortResponseBody could be made more resilient to rogue connections
   
   Since ReplyingServer binds to an open port on the system where tests
   run, it is possible some other program probes that port while the test
   is running. If the probe request does not have request params, the
   request is invalid and a test assertion fails. This commit replaces that
   assertion with returning a 400 response.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9329/files
  - new: https://git.openjdk.org/jdk/pull/9329/files/f8a56d1f..46125a78

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9329&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9329&range=00-01

  Stats: 7378 lines in 203 files changed: 4517 ins; 1389 del; 1472 mod
  Patch: https://git.openjdk.org/jdk/pull/9329.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9329/head:pull/9329

PR: https://git.openjdk.org/jdk/pull/9329


More information about the net-dev mailing list