RFR: 8282917: Remove InetAddressImplFactory from InetAddress [v3]

Daniel Fuchs dfuchs at openjdk.java.net
Wed Mar 16 17:54:50 UTC 2022


On Wed, 16 Mar 2022 17:51:17 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>> Hi,
>> 
>> This cleanup change removes `InetAddressImplFactory` class from `InetAddress`. The list of changes:
>> - Remove `InetAddressImplFactory` from `InetAddress`
>> - Since `isIPv6Supported` native code is identical for Windows and Unix implementations it was moved to the libnet's `InetAddress.c`.
>> - `InetAddressImplFactory.c` Windows and Unix implementations were removed
>> 
>> Testing: jdk-tier1 to jdk-tier3 tests show no failures related to the change
>
> Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Java_java_net_InetAddress_isIPv4Available signature comment

Thanks for checking the result returned by ipv6_available() and ipv4_available(). Based on that information I believe what you have is good.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7842


More information about the net-dev mailing list