RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v5]
Conor Cleary
ccleary at openjdk.java.net
Thu Mar 24 12:41:28 UTC 2022
On Tue, 22 Mar 2022 10:57:35 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Conor Cleary has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - 8263031: Added return statements and pcs var
>> - 8263031: Test cleanup, added third case
>> - Revert "Test cleanup, added third case"
>>
>> This reverts commit 5c1c0f5fea801923bc3352bf88c701768d78b11d.
>> - Test cleanup, added third case
>
> test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 158:
>
>> 156: CompletableFuture<HttpResponse<String>> cf =
>> 157: client.sendAsync(hreq, HttpResponse.BodyHandlers.ofString(UTF_8), pph);
>> 158: cf.join();
>
> I'd suggest checking that we received the expected response code + body too
Further changes made to check response codes and bodies of both the response and push promise.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7696
More information about the net-dev
mailing list