RFR: 8283544: HttpClient GET method adds Content-Length: 0 header [v6]

Conor Cleary ccleary at openjdk.java.net
Fri May 6 10:33:31 UTC 2022


> **Issue**
> When using the `HttpClient.send()` to send a GET request created using the `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This behaviour causes issues with many services as a body related header is usually not expected to be included with a GET request. 
> 
> **Solution**
> `Http1Request.java` was modified so that when the request method is a GET, a `Content-length` header is not added to the request. However, if a developer chooses to include a body in a GET request (though it is generally considered bad practice), a `Content-length` header with the appropriate value will be added.

Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:

  8283544: Improved logging, drain input stream

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8017/files
  - new: https://git.openjdk.java.net/jdk/pull/8017/files/c1ef7d29..83c6ca6e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8017&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8017&range=04-05

  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8017.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8017/head:pull/8017

PR: https://git.openjdk.java.net/jdk/pull/8017


More information about the net-dev mailing list