RFR: 8209137: Add ability to bind to specific local address to HTTP client [v18]

Daniel Fuchs dfuchs at openjdk.java.net
Tue May 10 13:41:49 UTC 2022


On Tue, 10 May 2022 13:36:18 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Daniel's review suggestion - add a test to verify the behaviour of the localAddress() default method implementation on HttpClient.Builder
>>  - Daniel's review suggestion - remove reference to "Internet Protocol" in javadoc
>
> test/jdk/java/net/httpclient/HttpClientBuilderTest.java line 283:
> 
>> 281:      * Tests that the default method implementation of
>> 282:      * {@link HttpClient,java.net.http.HttpClient.Builder#localAddress(InetAddress)} throws
>> 283:      * an {@link UnsupportedOperationException}
> 
> Same remark here

Otherwise things look good to me - you should update the CSR if it needs to be updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6690


More information about the net-dev mailing list