RFR: 8286386: Address possibly lossy conversions in java.net.http

[Michael McMahon]

On Wed, 11 May 2022 15:42:25 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> In relation to [JDK-8244681](https://bugs.openjdk.java.net/browse/JDK-8244681), please find here a patch that addresses possibly lossy conversions in java.net.http

src/java.net.http/share/classes/jdk/internal/net/http/hpack/QuickHuffman.java line 739:

> 737:                         buffer |= (codeValueOf(c) >>> bufferLen); // append
> 738:                         bufferLen += (int) len;
> 739:                         pos++;

Would it be cleaner to do the cast in the codeLengthOf method, so it returns an int?

src/java.net.http/share/classes/jdk/internal/net/http/websocket/Frame.java line 222:

> 220:                 // compiler will emit a warning if not cast
> 221:                 firstChar &= (char) ~0b10000000_00000000;
> 222:             }

Am I right in believing that there was an implicit cast to char here before and the only change is to make it explicit? ie. there is no actual behavior change?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8656