RFR: 8286386: Address possibly lossy conversions in java.net.http [v5]

Pavel Rappo prappo at openjdk.java.net
Thu May 12 09:19:59 UTC 2022


On Wed, 11 May 2022 18:42:46 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> In relation to [JDK-8244681](https://bugs.openjdk.java.net/browse/JDK-8244681), please find here a patch that addresses possibly lossy conversions in java.net.http
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert adding char constants

src/java.net.http/share/classes/jdk/internal/net/http/websocket/Frame.java line 291:

> 289: 
> 290:         HeaderWriter noMask() {
> 291:             // The negation "~" sets the high order bits

Rubber-stamping this in front of every of the four closely sitting casts seems excessive:

                // The negation "~" sets the high order bits
                // so the value is more than 16 bits and the
                // compiler will emit a warning if not cast

-------------

PR: https://git.openjdk.java.net/jdk/pull/8656


More information about the net-dev mailing list