Integrated: 8283544: HttpClient GET method adds Content-Length: 0 header

Conor Cleary ccleary at openjdk.java.net
Tue May 17 10:06:04 UTC 2022


On Tue, 29 Mar 2022 15:44:58 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

> **Issue**
> When using the `HttpClient.send()` to send a GET request created using the `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This behaviour causes issues with many services as a body related header is usually not expected to be included with a GET request. 
> 
> **Solution**
> `Http1Request.java` was modified so that when the request method is a GET, a `Content-length` header is not added to the request. However, if a developer chooses to include a body in a GET request (though it is generally considered bad practice), a `Content-length` header with the appropriate value will be added.

This pull request has now been integrated.

Changeset: 6a770932
Author:    Conor Cleary <ccleary at openjdk.org>
Committer: Daniel Fuchs <dfuchs at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/6a7709320d28d8e1593b113fdf39ab583fca3687
Stats:     248 lines in 2 files changed: 234 ins; 6 del; 8 mod

8283544: HttpClient GET method adds Content-Length: 0 header

Reviewed-by: dfuchs, jpai

-------------

PR: https://git.openjdk.java.net/jdk/pull/8017


More information about the net-dev mailing list