RFR: 8286873: Improve websocket test execution time
Daniel Fuchs
dfuchs at openjdk.java.net
Tue May 17 14:58:41 UTC 2022
On Tue, 17 May 2022 12:45:52 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This PR improves the execution time of jdk_net tests (and, by extension, tier2) by about 3 minutes.
>
> Tests located under `jdk/java/net/httpclient/websocket` are never run in parallel. Each of the 8 modified `Pending***` tests originally required 40 seconds to complete. After the proposed changes, they usually complete in 15 seconds.
>
> This PR modifies the tests to initially run with 1 second timeout. If the test fails with 1 second timeout, it is retried with timeout increased to 10 seconds (the original value).
>
> The modified tests were executed at least 10 times on each of: Windows, Linux (both x64 and aarch64), MacOS (both x64 and aarch64). No failures were observed.
Looks ok-ish. The idea of starting with a small timeout is a good one. I am a bit less sure about moving the post-asserts inside the loop - or closing before asserting that the cf hangs, but if I understand the logic correctly it seems ok too. Maybe give some time for @pavelrappo to chime in before integrating.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8746
More information about the net-dev
mailing list