RFR: 8295991: java/net/httpclient/CancelRequestTest.java fails intermittently [v2]

[Jaikiran Pai]

On Wed, 2 Nov 2022 12:34:58 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> The CancelRequestTest test has been observed failing (once). It was recently updated to verify that subscribers would be correctly unregistered after the request was cancelled. However, the timeout used to wait for that to happen was optimistically too short: the test code that cancels the request is by design racy, so it's not guaranteed that the subscriber will be unregistered before the completable future is cancelled, it might get unregistered asynchronously shortly after.
>> Increasing the timeout to wait for that to happen from 1ms to 100ms fixes the test issue.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into cancel-request-test-8295991
>  - Narrow down tracking to the client used by the test. Increase timeout.
>  - 8295991

This looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10931