RFR: 8288717: Add a means to close idle connections in HTTP/2 connection pool [v5]
Daniel Fuchs
dfuchs at openjdk.org
Thu Nov 3 18:37:10 UTC 2022
On Thu, 3 Nov 2022 16:37:45 GMT, Conor Cleary <ccleary at openjdk.org> wrote:
> * shutdown() in Http2Connection is returned to its original form. The existing code there is sufficient to log the idleConnectionTimeoutEvent once it fires.
I agree with this. If I read the code correctly the exception stack trace will be logged only if there are active stream, and in our case, the timeout should fire only when the connection is idle - so it should have no active stream. If it's being closed when there is an active stream then this is an error and we want to see it as such. The current code, as proposed here, does that.
-------------
PR: https://git.openjdk.org/jdk/pull/10183
More information about the net-dev
mailing list