RFR: 8288717: Add a means to close idle connections in HTTP/2 connection pool [v5]

Conor Cleary ccleary at openjdk.org
Mon Nov 7 12:39:37 UTC 2022


On Fri, 4 Nov 2022 09:42:05 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8288717: IdleConnectionTimeout can use Keep Alive or Custom Value
>
> src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java line 55:
> 
>> 53: final class ConnectionPool {
>> 54: 
>> 55:     static final long KEEP_ALIVE = KEEP_ALIVE_TIMEOUT; // seconds
> 
> I'd suggest removing line 55 and change the references below to KEEP_ALIVE_TIMEOUT

Yeah fair enough actually, I neglected to notice the slight duplication of code here (in terms of readability). I'll change this and see how it looks

-------------

PR: https://git.openjdk.org/jdk/pull/10183


More information about the net-dev mailing list