RFR: 8294378: URLPermission constructor exception when using tr locale [v3]
Aleksei Efimov
aefimov at openjdk.org
Fri Nov 11 12:56:34 UTC 2022
On Fri, 11 Nov 2022 11:48:51 GMT, Ryan Wallace <duke at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this fix for Invalid characters in hostname exception.
>> This was due to the URLPermission.parseURI() method calling String.toLowerCase() and returning a non ASCII characters in the case of the tr Locale. The fix was to use the HostPortrange.toLowerCase() method further down the stack which is Locale safe.
>>
>> Thanks,
>> Ryan.
>
> Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:
>
> - 8294378: Remove toLowerCase for auth url string to mitigate non ascii characters generated in URLPermission and change url to lowercase in HostPortrange
> - Merge branch 'master' into 8294378
> - Merge branch 'master' into 8294378
> - Merge branch 'master' into 8294378
> - 8294378: Remove toLowerCase for auth url string to mitigate non ascii characters generated in URLPermission and change url to lowercase in HostPortrange
> - Merge branch 'master' into 8294378
> - Merge branch 'master' into 8294378
> - Merge branch 'master' into 8294378
> - Merge branch 'master' into 8294378
> - Merge branch 'master' into 8294378
> - ... and 11 more: https://git.openjdk.org/jdk/compare/9f99edb5...e992f1f3
The latest changes look good to me. Thanks for fixing it
-------------
Marked as reviewed by aefimov (Committer).
PR: https://git.openjdk.org/jdk/pull/10903
More information about the net-dev
mailing list