RFR: 8288717: Add a means to close idle connections in HTTP/2 connection pool [v6]

[Daniel Fuchs]

On Mon, 7 Nov 2022 15:12:56 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

>> **Issue**
>> When using HTTP/2 with the HttpClient, it can often be necessary to close an idle Http2 Connection before a server sends a GOAWAY frame. For example, a server or cloud based tool could close a TCP connection silently when it is idle for too long resulting in ConnectionResetException being thrown by the HttpClient.
>> 
>> **Proposed Solution**
>> A new system property, `jdk.httpclient.idleConnectionTimeout`, was added and is used to specify in Milliseconds how long an idle connection (idle connections are those which have no currently active streams) for the HttpClient before the connection is closed.
>
> Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8288717: Added NumberFormatException log, refactored ConnectionPool

src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java line 114:

> 112:     static final AtomicLong CLIENT_IDS = new AtomicLong();
> 113:     private final AtomicLong CONNECTION_IDS = new AtomicLong();
> 114:     static final int DEFAULT_KEEP_ALIVE_TIMEOUT = 600;

Hi Conor, I believe we had agreed to keep the default value unchanged (1200) for now and log a followup issue to revisit this and provide a more suitable value. Could you do that before integrating?

-------------

PR: https://git.openjdk.org/jdk/pull/10183