RFR: 8297149: REDO JDK-8296889: Race condition when cancelling a request [v2]

Jaikiran Pai jpai at openjdk.org
Thu Nov 17 10:13:43 UTC 2022


On Thu, 17 Nov 2022 10:08:44 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Please find here a re-do fix for the race condition while cancelling request.
>> The previous fix failed because it registered the subscriber too late (after having called userSubsciber.onSubscribe()), which opened a window for the call to unregister to occur before the call to register.
>> This is fixed in this new iteration.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed onSubscribed() doc comment and override access qualifiers (protected vs public)

The latest changes in 60bbce6d look good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11193


More information about the net-dev mailing list