RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response [v2]
Jaikiran Pai
jpai at openjdk.org
Mon Nov 21 11:17:27 UTC 2022
> Can I please get a review for this small change which addresses https://bugs.openjdk.org/browse/JDK-8297211?
> The change checks if the `content-length` header value is present before parsing it into a `Long` value. The commit also now catches the more specific `NumberFormatException` instead of a general `Exception`. Given the context of the code, I believe this change in the exception type in the catch block should be fine.
>
> No new test has been introduced given the nature of this change. I have triggered existing tests to verify no unexpected regressions show up.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
review suggestion - do a similar change in URLConnection
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11258/files
- new: https://git.openjdk.org/jdk/pull/11258/files/0b18b96f..441d3770
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11258&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11258&range=00-01
Stats: 21 lines in 1 file changed: 8 ins; 0 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/11258.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11258/head:pull/11258
PR: https://git.openjdk.org/jdk/pull/11258
More information about the net-dev
mailing list