RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response [v2]

Jaikiran Pai jpai at openjdk.org
Mon Nov 21 13:42:58 UTC 2022


On Mon, 21 Nov 2022 12:49:20 GMT, Hannes Greule <duke at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review suggestion - do a similar change in URLConnection
>
> src/java.base/share/classes/java/net/URLConnection.java line 680:
> 
>> 678:             try {
>> 679:                 return Date.parse(value);
>> 680:             } catch (NumberFormatException e) { }
> 
> (not a reviewer) I think NumberFormatException isn't sufficient here. `Date.parse` might throw an `IllegalArgumentException`.

You are right @SirYwell. It was a copy/paste error on my part. Thank you for catching it. I have updated the PR to fix that part and catch `Exception` like previously.

-------------

PR: https://git.openjdk.org/jdk/pull/11258


More information about the net-dev mailing list