RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response [v3]

Mon Nov 21 15:27:58 UTC 2022

On Mon, 21 Nov 2022 13:36:15 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review for this small change which addresses https://bugs.openjdk.org/browse/JDK-8297211? 
>> The change checks if the `content-length` header value is present before parsing it into a `Long` value. The commit also now catches the more specific `NumberFormatException` instead of a general `Exception`. Given the context of the code, I believe this change in the exception type in the catch block should be fine.
>> 
>> No new test has been introduced given the nature of this change. I have triggered existing tests to verify no unexpected regressions show up.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment - fix Date.parse exception handling

LGTM.

-------------

Marked as reviewed by simonis (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11258