Integrated: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response

Jaikiran Pai jpai at openjdk.org
Tue Nov 22 01:52:05 UTC 2022


On Mon, 21 Nov 2022 06:47:52 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this small change which addresses https://bugs.openjdk.org/browse/JDK-8297211? 
> The change checks if the `content-length` header value is present before parsing it into a `Long` value. The commit also now catches the more specific `NumberFormatException` instead of a general `Exception`. Given the context of the code, I believe this change in the exception type in the catch block should be fine.
> 
> No new test has been introduced given the nature of this change. I have triggered existing tests to verify no unexpected regressions show up.

This pull request has now been integrated.

Changeset: 392ac705
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/392ac7055d4697c56fa85ac5572f5bc4dc431f1d
Stats:     25 lines in 2 files changed: 9 ins; 0 del; 16 mod

8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response

Reviewed-by: simonis, dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/11258


More information about the net-dev mailing list