RFR: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections [v2]

Daniel Fuchs dfuchs at openjdk.org
Tue Nov 22 16:51:30 UTC 2022


On Tue, 22 Nov 2022 16:24:52 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - Update test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java line 83:
> 
>> 81:     // The number of time an idle timeout was detected by any worker
>> 82:     // on the server side.
>> 83:     static final AtomicInteger IDLE_TIME_EXCEEDED = new AtomicInteger();
> 
> IDLE_TIME_EXCEEDED is allocated and incremented, but not referenced anywhere else. Did you mean to include it in a debug log or something?

Yes - I meant to use it but in the end it was also necessary to include the time the worker has been idle since it last read/wrote a byte and the end of the test (the time at which all requests had been sent) - so I ended up not using it.  I could remove it.

-------------

PR: https://git.openjdk.org/jdk/pull/11268


More information about the net-dev mailing list