RFR: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections [v4]

Daniel Fuchs dfuchs at openjdk.org
Wed Nov 23 11:45:23 UTC 2022


On Wed, 23 Nov 2022 08:16:14 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Incorporated review feedback
>
> test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java line 28:
> 
>> 26:  * @bug 4636628
>> 27:  * @summary HttpURLConnection duplicates HTTP GET requests when used with multiple threads
>> 28:  * @run main MultiThreadTest
> 
> do we really need to run this test 5 times?

Good point. I will remove them. That was just my trick for increasing the chances of failures while testing the change.

> test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java line 183:
> 
>> 181:         try {
>> 182:             Object lock = MultiThreadTest.getLock();
>> 183:             List<MultiThreadTest> tests = new ArrayList<>();
> 
> this list is not used

Good catch. That's a left over from some additional experiment.

-------------

PR: https://git.openjdk.org/jdk/pull/11268


More information about the net-dev mailing list