RFR: 8051627: Invariants about java.net.URI resolve and relativize are wrong [v2]
KIRIYAMA Takuya
duke at openjdk.org
Thu Nov 24 04:09:20 UTC 2022
On Wed, 28 Sep 2022 11:11:29 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> @dfuch
>> Thank you for your review and suggestions.
>>
>>> A colon ':' may be more appropriate than a period '.' at the end of this sentence:
>>> I'd suggest:
>>
>> You’re right. I changed to use a colon.
>>
>>> Could you update the UriTest with some examples and counter-examples to validate this claim?
>>
>> I added tests in URI/Test.java.
>> The tests include testing if the resolve-relativize relationship stand when the two URIs meet the condition of the modified javadoc.
>> The tests also include testing if the relationship does not stand when the two specific URIs which meets the condition of the original javadoc are given. These URIs are excluded by the condition of the modiied javadoc.
>
> Hi @tkiriyama sorry for taking so long to get back to you. I had a look at the CSR - and fixed a few missing fields, and added myself as reviewer. Please move its state to "Proposed" to get this moving further.
@dfuch
The CSR of this pull request was moved to "CLOSED".
Could you review this pull request again?
-------------
PR: https://git.openjdk.org/jdk/pull/9671
More information about the net-dev
mailing list