RFR: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections [v6]
Daniel Fuchs
dfuchs at openjdk.org
Thu Nov 24 11:53:15 UTC 2022
On Thu, 24 Nov 2022 11:10:53 GMT, Michael McMahon <michaelm at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Use the tests list to simplify the logic of waiting for clients to finish
>
> test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java line 193:
>
>> 191: // our client. We should only count those workers for which
>> 192: // the expected header has been found.
>> 193: int validConnections = 0;
>
> Could you also add a comment like:
>
> // We detect worker threads that may have timed out, so we don't include them in
> // the count to compare with the number of connections.
>
> Otherwise, LGTM
Done!
-------------
PR: https://git.openjdk.org/jdk/pull/11268
More information about the net-dev
mailing list