RFR: 8294047: HttpResponseInputStream swallows interrupts [v2]

Darragh Clarke duke at openjdk.org
Fri Nov 25 16:10:11 UTC 2022


On Fri, 25 Nov 2022 11:28:46 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   implemented feedback
>
> src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 489:
> 
>> 487:                     } catch (IOException ignored) {
>> 488:                     }
>> 489:                     throw new InterruptedIOException();
> 
> Thanks for doing that. Maybe we should keep the caught InterruptedException as the cause of the new InterruptedIOException. I'd suggest to add a new utility method to the `...common.Utils` class for that. I mean - something like:
> 
>     InterruptedIOException Utils.toInterruptedIOException(InterruptedException ex);

So  something in utils like `return new InterruptedIOException(String.valueOf(exxeption));` ?

-------------

PR: https://git.openjdk.org/jdk/pull/11323


More information about the net-dev mailing list