RFR: 8297311: Improve exception message thrown by java.net.HostPortrange::toLowerCase(String s) [v2]

Daniel Fuchs dfuchs at openjdk.org
Tue Nov 29 12:56:04 UTC 2022


On Tue, 29 Nov 2022 12:52:35 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to enhance an exception message in `java.net.HostPortrange::toLowerCase`, as requested in https://bugs.openjdk.org/browse/JDK-8297311?
>> 
>> The commit here includes (only) the character, which was found to be invalid, in the exception message. The character will be printed out in `\uXXXX` format to take into account any unprintable characters.
>> 
>> A new test has been introduced to verify that the introduction of this change doesn't introduce any regression and does indeed include the expected exception message.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Marked as reviewed by dfuchs (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11407


More information about the net-dev mailing list