RFR: 8297609: Add application/wasm MIME type for wasm file extension
Daniel Fuchs
dfuchs at openjdk.org
Tue Nov 29 19:56:03 UTC 2022
On Tue, 29 Nov 2022 13:06:37 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> @jaikiran Thanks.
>
> Hello @Karm, we have an existing test in the JDK which verifies the expected mime types for some well known extensions. It resides at `test/jdk/java/nio/file/Files/probeContentType/Basic.java`. Could you update that test's main method to include a test for this new mime type that this PR adds?
>
> I suspect it would be as simple as adding this new entry to this array here https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/file/Files/probeContentType/Basic.java#L189
> @jaikiran Would you like me to squash those two commits and force push in that branch? I am not really familiar with the JDK project's GitHub flow and I don't want to disturb any bots with messing up the PR commit history. Thx for advice...
Commits will be automatically squashed by the bot when you /integrate - so there's no need to force-push. In fact this is even discouraged as it messes up with feedback made by reviewers on previous iterations of the PR. So please don't force-push :-)
-------------
PR: https://git.openjdk.org/jdk/pull/11284
More information about the net-dev
mailing list