RFR: 8294047: HttpResponseInputStream swallows interrupts [v4]

Vyom Tewari vtewari at openjdk.org
Wed Nov 30 05:21:28 UTC 2022


On Mon, 28 Nov 2022 14:21:01 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Currently if a `HttpResonseInputStream` gets interrupted while reading it will just swallow the exception and continue,
>> 
>> This PR changes it to close the stream and throw an IOException, I added a test to cover this which just uses two threads to read the stream then interrupt it.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed copyright year and formatting of a comment

src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 491:

> 489:                     // Throw InterruptedIOException where the initCause is
> 490:                     // set to the caught InterruptedException
> 491:                     throw Utils.toInterruptedIOException(ex);

Don't you think you need to  restores the interrupt status of the thread by invoking the Thread.currentThread().interrupt() method and allowing the caller to detect the interrupt if it needs to ?

-------------

PR: https://git.openjdk.org/jdk/pull/11323


More information about the net-dev mailing list