RFR: 8282395: URL.openConnection can throw IOOBE [v5]
KIRIYAMA Takuya
duke at openjdk.org
Wed Oct 5 09:22:04 UTC 2022
> I fixed sun.net.www.ParseUtil.decode().
>
> ParseUtil.decode() always tries to decode after parsing '%', so if '%' is located at the end of the String, IndexOutOfBoundsException is thrown. Also, if '%' is shown after decodable string and following string is not decodable (e.g: "%25%s%G1"), ParseUtil.decode() throws IllegalArgumentException.
>
> But URL standard says below (https://url.spec.whatwg.org/#percent-decode).
>
>
> Otherwise, if byte is 0x25 (%) and the next two bytes after byte in input are not in the ranges
> 0x30 (0) to 0x39 (9), 0x41 (A) to 0x46 (F), and 0x61 (a) to 0x66 (f), all inclusive, append byte to output.
>
>
> So, there should be used isEscaped() to judge to decode.
>
> Would you please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
8282395: URL.openConnection can throw IOOBE
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/8155/files
- new: https://git.openjdk.org/jdk/pull/8155/files/b3997951..2064a478
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=8155&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=8155&range=03-04
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/8155.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/8155/head:pull/8155
PR: https://git.openjdk.org/jdk/pull/8155
More information about the net-dev
mailing list