RFR: 8282395: URL.openConnection can throw IOOBE [v4]

KIRIYAMA Takuya duke at openjdk.org
Wed Oct 5 09:22:08 UTC 2022


On Fri, 30 Sep 2022 13:40:49 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8282395: URL.openConnection can throw IOOBE
>
> src/java.base/share/classes/sun/net/www/ParseUtil.java line 200:
> 
>> 198:             int ui = i;
>> 199:             for (;;) {
>> 200:                 if (n - i >= 2) {
> 
> OK - the test should be inverted - sorry for not noticing that earlier. It should be `n - i < 2`. It's causing massive failures in the CI. Can you please run at least the tests under jdk/sun/net and jdk/java/net after making the change?

I am sorry for my bad mistake.
I fixed it and run the tests under jdk/sun/net and jdk/java/net. I confirmed all tests passed in Linux.

-------------

PR: https://git.openjdk.org/jdk/pull/8155


More information about the net-dev mailing list