RFR: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers [v2]

Aleksei Efimov aefimov at openjdk.org
Fri Oct 7 16:11:20 UTC 2022


On Fri, 7 Oct 2022 11:18:15 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Changed the way the `:authority` pseudo header is set to only include host and, if available, port.
>> I added a test to cover this change that consists of a HttpClient that makes a request which contains userInfo, the test passes if the request is carried out with the userInfo not being added to the `:authority` header.
>> 
>> 
>> ### Tests
>> I ran Tier 1 - Tier 3 tests, as well as paying special attention to the http client tests to make sure they consistently passed
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed formatting, added finally to cleanup server if test fails

Thanks for the changes. LGTM

-------------

Marked as reviewed by aefimov (Committer).

PR: https://git.openjdk.org/jdk/pull/10592


More information about the net-dev mailing list