RFR: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers [v3]

[Daniel Fuchs]

On Mon, 10 Oct 2022 13:43:53 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Changed the way the `:authority` pseudo header is set to only include host and, if available, port.
>> I added a test to cover this change that consists of a HttpClient that makes a request which contains userInfo, the test passes if the request is carried out with the userInfo not being added to the `:authority` header.
>> 
>> 
>> ### Tests
>> I ran Tier 1 - Tier 3 tests, as well as paying special attention to the http client tests to make sure they consistently passed
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implemented feedback

Changes requested by dfuchs (Reviewer).

Also you could start using junit5 for the test instead instead of testng.

test/jdk/java/net/httpclient/http2/UserInfoTest.java line 87:

> 85:                 .build();
> 86: 
> 87:         URI uri = new URI("https://user@127.0.0.1:" + Integer.toString(port));

Some machines may not have an IPv4 stack configured. It would be better to use the test lib URIBuilder here to take care of this possibility. Also there's no need for `Integer.toString()`

-------------

PR: https://git.openjdk.org/jdk/pull/10592