RFR: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers [v4]

Daniel Fuchs dfuchs at openjdk.org
Mon Oct 10 18:04:54 UTC 2022


On Mon, 10 Oct 2022 17:01:51 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Changed the way the `:authority` pseudo header is set to only include host and, if available, port.
>> I added a test to cover this change that consists of a HttpClient that makes a request which contains userInfo, the test passes if the request is carried out with the userInfo not being added to the `:authority` header.
>> 
>> 
>> ### Tests
>> I ran Tier 1 - Tier 3 tests, as well as paying special attention to the http client tests to make sure they consistently passed
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changed test to junit, use URIBuilder

test/jdk/java/net/httpclient/http2/UserInfoTest.java line 74:

> 72:     }
> 73: 
> 74:     public void main() throws Exception {

Have you verified in the log that main() is actually called?

-------------

PR: https://git.openjdk.org/jdk/pull/10592


More information about the net-dev mailing list