RFR: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers [v6]
Daniel Fuchs
dfuchs at openjdk.org
Thu Oct 13 15:12:37 UTC 2022
On Thu, 13 Oct 2022 11:21:57 GMT, Darragh Clarke <duke at openjdk.org> wrote:
>> Changed the way the `:authority` pseudo header is set to only include host and, if available, port.
>> I added a test to cover this change that consists of a HttpClient that makes a request which contains userInfo, the test passes if the request is carried out with the userInfo not being added to the `:authority` header.
>>
>>
>> ### Tests
>> I ran Tier 1 - Tier 3 tests, as well as paying special attention to the http client tests to make sure they consistently passed
>
> Darragh Clarke has updated the pull request incrementally with three additional commits since the last revision:
>
> - check authority pseudoheader directly
> - removed unused import
> - test cleanup
Good work!
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10592
More information about the net-dev
mailing list