RFR: 8294916: Cancelling a request must eventually cause its response body subscriber to be unregistered [v6]

Daniel Fuchs dfuchs at openjdk.org
Tue Oct 18 13:50:09 UTC 2022


On Tue, 18 Oct 2022 12:45:50 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright years
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java line 642:
> 
>> 640:         final long webSocketCount = pendingWebSocketCount.get();
>> 641:         if (count == 0 && facadeRef.refersTo(null)) {
>> 642:             selmgr.wakeupSelector();
> 
> I notice there is only one remaining reference to the facade() method. It might make sense to get rid of it and replace the call site with `facadeRef.refersTo`

The only remaining call I see is here:

        return new BuilderImpl(this.facade(), proxySelector);

and that call needs to return the facade - we can't replace it with `refersTo`. I'm not seeing any other calls.

-------------

PR: https://git.openjdk.org/jdk/pull/10659


More information about the net-dev mailing list