RFR: 8294948: Document IllegalArgumentException and NullPointerException thrown by URLStreamHandler::parseURL and URLStreamHandler::setURL [v8]

Alan Bateman alanb at openjdk.org
Wed Oct 19 12:48:58 UTC 2022


On Wed, 19 Oct 2022 12:13:44 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> src/java.base/share/classes/java/net/URL.java line 580:
>> 
>>> 578:      * @implSpec Parsing the URL involves calling the {@link
>>> 579:      * URLStreamHandler#parseURL(URL, String, int, int) parseURL} method on the
>>> 580:      * selected handler.
>> 
>> What you would think about making this more direct, e.g. "This constructor invokes the selected stream handler's parseURL method to parse the URL."
>
> Well some of the parsing is done in URL itself: like finding the fragment, if any, setting up start and limit etc... And I didn't want to get into the rabbit hole of trying to specify what does what exactly. I can still take your suggested text if you believe it doesn't matter?

Okay, maybe your wording would be be okay if you changed "involves" to "includes" as the former hints that there is more going on that is not specified.

-------------

PR: https://git.openjdk.org/jdk/pull/10609


More information about the net-dev mailing list