RFR: 8294948: Document IllegalArgumentException and NullPointerException thrown by URLStreamHandler::parseURL and URLStreamHandler::setURL [v8]

Daniel Fuchs dfuchs at openjdk.org
Wed Oct 19 14:14:54 UTC 2022


On Wed, 19 Oct 2022 11:27:01 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - More review comments
>>  - Taking into account review feedback
>>  - Merge branch 'master' into url-iae-8294948
>>  - Merge branch 'master' into url-iae-8294948
>>  - Minor wording updates - unmmapable single quote character
>>  - Minor wording updates
>>  - Update Copyright Years
>>  - Adding missing @throws NPE
>>  - 8294948
>>  - 8294948
>
> src/java.base/share/classes/java/net/URL.java line 590:
> 
>> 588:      *               underlying stream handler's {@linkplain
>> 589:      *               URLStreamHandler#parseURL parseURL method} throws
>> 590:      *               {@code IllegalArgumentException}
> 
> This looks okay but it might be simpler to drop "In particular" and just say "or the stream handler's parseURL throws ...".

Thanks @AlanBateman I have pushed all the requested changes and updated the CSR. If that looks good to you I will finalize the CSR.

-------------

PR: https://git.openjdk.org/jdk/pull/10609


More information about the net-dev mailing list