RFR: 8288493: Document JDK specific system properties in jdk.httpserver [v5]

Jaikiran Pai jpai at openjdk.org
Thu Oct 20 10:40:57 UTC 2022


On Thu, 20 Oct 2022 08:05:09 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> This change adds some documentation to the jdk.httpserver module-info listing all of the system properties used by the implementation and which can be set by users.
>> 
>> CSR at https://bugs.openjdk.org/browse/JDK-8295667
>> 
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   blank line removed

src/jdk.httpserver/share/classes/module-info.java line 44:

> 42:  * <p>
> 43:  * The following is a list of JDK specific system properties used by the HTTP
> 44:  * server implementation.

Hello Michael, given that the HttpServer is based on a SPI and the `sun.net.httpserver.HttpServerImpl`  (and its Https equivalent) are just default implementations, should either of these 2 sentences note that these system properties are only applicable for the default HttpServer implementation? Something like:

>
><b id="httpserverprops">System properties used by the default HTTP server</b>
The following is a list of JDK specific system properties used by the default HTTP server implementation.

-------------

PR: https://git.openjdk.org/jdk/pull/10766


More information about the net-dev mailing list