RFR: 8288493: Document JDK specific system properties in jdk.httpserver [v5]

Daniel Fuchs dfuchs at openjdk.org
Thu Oct 20 11:55:55 UTC 2022


On Thu, 20 Oct 2022 11:01:26 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/jdk.httpserver/share/classes/module-info.java line 44:
>> 
>>> 42:  * <p>
>>> 43:  * The following is a list of JDK specific system properties used by the HTTP
>>> 44:  * server implementation.
>> 
>> Hello Michael, given that the HttpServer is based on a SPI and the `sun.net.httpserver.HttpServerImpl`  (and its Https equivalent) are just default implementations, should either of these 2 sentences note that these system properties are only applicable for the default HttpServer implementation? Something like:
>> 
>>>
>>><b id="httpserverprops">System properties used by the default HTTP server</b>
>> The following is a list of JDK specific system properties used by the default HTTP server implementation.
>
> Maybe, I should include the property that is used to locate the impl as first in the list and say the remaining properties apply to the default impl in the JDK?

No. That property should probably be deprecated since there is a more modern (ServiceLoader based) alternative implemented. But you could refer to the `@uses com.sun.net.httpserver.spi.HttpServerProvider` service.

-------------

PR: https://git.openjdk.org/jdk/pull/10766


More information about the net-dev mailing list