RFR: 8288493: Document JDK specific system properties in jdk.httpserver [v5]

Jaikiran Pai jpai at openjdk.org
Thu Oct 20 12:22:50 UTC 2022


On Thu, 20 Oct 2022 11:01:23 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/jdk.httpserver/share/classes/module-info.java line 83:
>> 
>>> 81:  * exceeded then the connection is terminated and the handler will receive a
>>> 82:  * {@link java.io.IOException}. This timer has an implementation specific granularity
>>> 83:  * that may mean responses are aborted later than the specified interval.
>> 
>> I think the `maxReqTime` and the `maxRspTime` will need a bit more clarification on how they differ. Specifically the `maxReqTime` as used by the current server implementation is the duration to read the entire request content. It however, doesn't include the time it takes to generate the response nor process the request through the handler.
>
> Okay, I can specifically refer to "request headers and body" and "response headers and body".
> 
> So, for example replace "The maximum duration in milliseconds of a request." with
> 
> "The maximum time in milliseconds allowed to receive the request headers and body".

That wording sounds good to me.

-------------

PR: https://git.openjdk.org/jdk/pull/10766


More information about the net-dev mailing list