RFR: 8266900: java/net/httpclient/ShortResponseBody.java fails on windows with java.io.IOException: Unable to establish loopback connection [v2]

[Daniel Jeliński]

On Thu, 20 Oct 2022 13:49:42 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Really change client every 10 requests
>
> test/jdk/java/net/httpclient/ShortResponseBody.java line 135:
> 
>> 133:             }
>> 134:         }
>> 135:         numberOfRequests++;
> 
> Did you mean `numberOfRequests = (numberOfRequests % REQUESTS_PER_CLIENT) + 1;` to match the description of the changes?

Good catch! Forgot to reset the counter. Fix pushed.

> test/jdk/java/net/httpclient/ShortResponseBody.java line 706:
> 
>> 704:     @AfterTest
>> 705:     public void teardown() throws Exception {
>> 706:         if (sharedClient != null) sharedClient = null;
> 
> should probably null `client` here?

Not necessary. `client` is an instance field and will be GCed as soon as the framework is done with the test.

-------------

PR: https://git.openjdk.org/jdk/pull/10794